Skip to content

i18n(ja-JP): add Japanese locale #159 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

i18n(ja-JP): add Japanese locale #159 #165

wants to merge 10 commits into from

Conversation

LylaB
Copy link

@LylaB LylaB commented Sep 24, 2025 •
edited
Loading

e2e: N/A (not applicable for locale addition)

Manual test: Checked locally, Japanese labels render correctly

UX/UI: N/A

Documentation: N/A

Unit/Integration tests: N/A

----------original message------------------

Purpose

Related Issues

  • 161

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

brionmario
brionmario reviewed Sep 29, 2025
View reviewed changes
packages/javascript/src/i18n/ja-JP.ts
Copy link
Member

@brionmario brionmario Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please validate the formatting of this file.

Use ctrl+shift+p -> Format Document on VSCode. Make sure prettier is selected as the formatter.

Also verify whether the necessary development tools are configured: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#development-tools

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please follow this guide: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#contributing-to-the-internalization-i18n-package
Since we now have a dedicate i18n pacakge.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review :)
Since I'm new to Github, not used to reflect the feedbacks.
Could you please confirm all the things you said mirrored properly?
If that’s the case, I’ll go ahead and remove the old file from the PR.

Best regards!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we go ahead and remove the old file and re-clone en-US and only modify the content without touching the formatting?

Also please try to follow out commit message guideline : https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#commit-message-guidelines

You had it right the first time :)

Let me know if you need any help.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope I mirrored everything right this time... 🥺
Would you please review my PR again?

Thanks.

@brionmario
Copy link
Member

Hey @LylaB,

Thanks for the PR.

Can you please update the PR description? Please link the issue you worked on as well.

@LylaB
Update ja-JP.ts
c7805bc
@LylaB
Merge branch 'asgardeo:main' into patch-1
d6ab4e5
@LylaB
Create ja-JP.ts in new file directory
6e9ba28 
### Summary
Add Japanese locale (ja-JP) translations.

### Related Issue
Fixes asgardeo#161 

e2e: N/A (not applicable for locale addition)

Manual test: Checked locally, Japanese labels render correctly

UX/UI: N/A

Documentation: N/A

Unit/Integration tests: N/A

Security: Confirmed, no secrets committed

----------original message------------------

### Purpose
<!-- Describe the problem, feature, improvement or the change introduces by the PR briefly. Add screenshots/GIFs if UI/UX changes are introduced. -->

### Related Issues
- 

### Related PRs
- 

### Checklist
- [ ] e2e cypress tests locally verified.
- [ ] Manual test round performed and verified.
- [ ] UX/UI review done on the final implementation.
- [ ] Documentation provided. (Add links if there are any)
- [ ] Unit tests provided. (Add links if there are any)
- [ ] Integration tests provided. (Add links if there are any)

### Security checks
- [ ] Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines?
- [ ] Ran FindSecurityBugs plugin and verified report?
- [ ] Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
brionmario
brionmario previously approved these changes Oct 1, 2025
View reviewed changes
packages/javascript/src/i18n/ja-JP.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we go ahead and remove the old file and re-clone en-US and only modify the content without touching the formatting?

Also please try to follow out commit message guideline : https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#commit-message-guidelines

You had it right the first time :)

Let me know if you need any help.

@brionmario brionmario dismissed their stale review October 1, 2025 08:19

Needs a bit more changes

@brionmario
Copy link
Member

Hey @LylaB,

packages/i18n/src/translations/ja-JP.ts This file looks fine.

Can we remove the old one: packages/javascript/src/i18n/ja-JP.ts

Also update the index.ts file: https://github.com/asgardeo/javascript/blob/main/packages/i18n/src/translations/index.ts

Guide: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#contributing-to-the-internalization-i18n-package

Also create a changeset following: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#creating-a-changeset

Reference PR: #188

@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario
Copy link
Member

Hey @LylaB,

Still the translation is inside packages/javascript. It should be moved to packages/i18n.

If its easier for you, shall we close this PR and open up a new one?

Follow this guide: https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#contributing-to-the-internalization-i18n-package

Here's a PR for your reference:

Also follow our commit message guideline:

@LylaB
Copy link
Author

LylaB commented Oct 7, 2025

Hi, @brionmario
So so sorry for the late response. I wanted to finished mirroring feedback yesterday but while I'm working on this, other urgent thing came up. I will make sure to reflect all the feedback by end or tmr. Again, sorry for slow response

@brionmario
Copy link
Member

Hi, @brionmario So so sorry for the late response. I wanted to finished mirroring feedback yesterday but while I'm working on this, other urgent thing came up. I will make sure to reflect all the feedback by end or tmr. Again, sorry for slow response

Hey,

No worries 🙌 . Take the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brionmario brionmario brionmario left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LylaB @brionmario @asgardeo-github-bot